Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translatable strings to healthcare field #935

Merged
merged 5 commits into from
Jul 4, 2023

Conversation

kjonosm
Copy link
Contributor

@kjonosm kjonosm commented Jun 24, 2023

No description provided.

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-935--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we should be consistent between existing presets and the strings of the corresponding combo fields, see suggestions below.

data/fields/healthcare.json Outdated Show resolved Hide resolved
data/fields/healthcare.json Outdated Show resolved Hide resolved
data/fields/healthcare.json Outdated Show resolved Hide resolved
data/fields/healthcare.json Outdated Show resolved Hide resolved
kjonosm and others added 4 commits June 27, 2023 19:48
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
@tyrasd tyrasd merged commit f9e0e2b into openstreetmap:main Jul 4, 2023
@kjonosm kjonosm deleted the patch-36 branch July 4, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants