Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets for common taxi vehicles found in developing regions #946

Merged
merged 24 commits into from
Jul 21, 2023

Conversation

govvin
Copy link
Contributor

@govvin govvin commented Jul 5, 2023

Added the following preset combos for taxis, by taxi_vehicle types.

  • Auto Rickshaw - amenity=taxi +taxi_vehicle=auto_rickshaw
  • Cycle Rickshaw - amenity=taxi +taxi_vehicle=cycle_rickshaw
  • Motorcycle Taxi Stand - amenity=taxi +taxi_vehicle=motorcycle
  • Add taxi_vehicle.json field
  • Update taxi.json, to allow selecting taxi_vehicle

This is my first time to do something like this, adding a preset for a combination of tags. Icons could be better.

Is this how it's done?

govvin added 4 commits July 5, 2023 11:35
Add preset for auto_rickshaw.
Create an easy preset for amenity=taxi+taxi_vehicle=cycle_rickshaw, for cycle rickshaw stands, popular in many developing countries.
Add an easy preset for amenity=taxi+taxi_vehicle=motorcycle combo, for taxi stands of this type, found in many developing regions.
Remove extra comma.
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

🍱 Preview the tagging presets of this pull request here: https://pr-946--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

govvin added 12 commits July 7, 2023 06:24
Move "taxi_vehicle" field to tags.
Move "taxi_vehicle" field to tags section.
Move taxi_vehicle field to tags section.
Add field "taxi_vehicle", to help indicate the type of vehicle used by taxis from this stand.
Create field taxi_vehicle.json, for use in amenity=taxi, to identify the type of vehicle to expect from a taxi stand.
Fix quotation marks.
Remove extra space
Add more common terms, as examples.
Switch icon from "fas-people-pulling", to  "roentgen-bus_stop_sign".
Change term entry to alias, "tricycle terminal", based on user feedback.
Add "Pedicab Terminal" as alias, from user suggestion.
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of this tag is currently still low, but it seems to be new and rapidly becoming more popular.

One question which came to my mind is: how common is it to see stands with mixed vehicles (e.g. auto_rickshaw and motorcycle, etc.)? If they are somewhat common, the field could be changed into a semiCombo type to support that as well.

I see that you reduced the number of included fields in the presets for the sub-types. Would it not make sense to keep these consistent with the "main" taxi preset?

See a few additional comments/suggestions below.

data/fields/taxi_vehicle.json Outdated Show resolved Hide resolved
data/presets/amenity/taxi.json Outdated Show resolved Hide resolved
data/presets/amenity/taxi/auto_rickshaw.json Show resolved Hide resolved
govvin and others added 8 commits July 11, 2023 15:47
Revise field type to "semicombo", and separate description text from options.
move "taxi_vehicle" to moreFields section.
Add "bajaj"

Co-authored-by: Martin Raifer <martin@raifer.tech>
Fix typo in type to "semiCombo"
Move help tips from description to title section.
Retain similar fields from taxi.json for consistency.
Retain similar fields from taxi.json for consistency.
Retain similar fields from taxi.json for consistency.
@tyrasd
Copy link
Member

tyrasd commented Jul 18, 2023

@govvin is this ready to be reviewed now?

@govvin govvin marked this pull request as ready for review July 18, 2023 22:36
@govvin
Copy link
Contributor Author

govvin commented Jul 18, 2023

@tyrasd , yes, please. :)

@govvin is this ready to be reviewed now?

@tyrasd tyrasd merged commit 707101f into openstreetmap:main Jul 21, 2023
@govvin govvin deleted the rickshaw branch July 21, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants