-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presets for common taxi vehicles found in developing regions #946
Conversation
Add preset for auto_rickshaw.
Create an easy preset for amenity=taxi+taxi_vehicle=cycle_rickshaw, for cycle rickshaw stands, popular in many developing countries.
Add an easy preset for amenity=taxi+taxi_vehicle=motorcycle combo, for taxi stands of this type, found in many developing regions.
Remove extra comma.
🍱 Preview the tagging presets of this pull request here: https://pr-946--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
Move "taxi_vehicle" field to tags.
Move "taxi_vehicle" field to tags section.
Move taxi_vehicle field to tags section.
Add field "taxi_vehicle", to help indicate the type of vehicle used by taxis from this stand.
Create field taxi_vehicle.json, for use in amenity=taxi, to identify the type of vehicle to expect from a taxi stand.
Fix quotation marks.
Remove extra space
Add more common terms, as examples.
Switch icon from "fas-people-pulling", to "roentgen-bus_stop_sign".
Change term entry to alias, "tricycle terminal", based on user feedback.
Add "Pedicab Terminal" as alias, from user suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage of this tag is currently still low, but it seems to be new and rapidly becoming more popular.
One question which came to my mind is: how common is it to see stands with mixed vehicles (e.g. auto_rickshaw
and motorcycle
, etc.)? If they are somewhat common, the field could be changed into a semiCombo
type to support that as well.
I see that you reduced the number of included fields in the presets for the sub-types. Would it not make sense to keep these consistent with the "main" taxi
preset?
See a few additional comments/suggestions below.
Revise field type to "semicombo", and separate description text from options.
move "taxi_vehicle" to moreFields section.
Add "bajaj" Co-authored-by: Martin Raifer <martin@raifer.tech>
Fix typo in type to "semiCombo"
Move help tips from description to title section.
Retain similar fields from taxi.json for consistency.
Retain similar fields from taxi.json for consistency.
Retain similar fields from taxi.json for consistency.
@govvin is this ready to be reviewed now? |
Added the following preset combos for taxis, by
taxi_vehicle
types.amenity=taxi
+taxi_vehicle=auto_rickshaw
amenity=taxi
+taxi_vehicle=cycle_rickshaw
amenity=taxi
+taxi_vehicle=motorcycle
taxi_vehicle.json
fieldtaxi_vehicle
This is my first time to do something like this, adding a preset for a combination of tags. Icons could be better.
Is this how it's done?