Allow connections over TCP besides Unix sockets for tools #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Austermühle <au@hcsd.de>
|
Many thanks for the PR. This looks like a good enhancement. I would like to keep it open a bit to allow others to share their opinions. |
|
For those who long for this PR to be merged like me I present (temporary) UNIX solution:
Make your renderd available by IP & PORT. Create socket file with socat so u could use render tools with |
|
Thanks a lot for your contribution @stephan2012. |
This was referenced Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephan Austermühle au@hcsd.de
Fixes #137
This PR allows tools like
render_listto connect torenderdover network instead of local Unix sockets allowing for easy separation ofmod_tileandrenderd. Also, it enables connecting to dynamically scalingrenderdinstances (e.g., when deployed on a Kubernetes cluster). Simply pass-s ‹hostname›:‹tcpPort›instead of a Unix socket path to use.Feedback on this PR is welcome.