Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for installing from distribution packages #330

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

hummeltech
Copy link
Collaborator

@hummeltech hummeltech commented Jul 23, 2023

In order to ensure that the instructions contained within README.rst also work when installing mod_tile packages from Debian/Ubuntu repositories, I have added a basic test which first installs those packages and then executes the same commands from the aforementioned instructions.

Here is an example of a workflow run:
https://github.com/hummeltech/mod_tile/actions/runs/5638547864

Also:

  • Add additional image format types into example configuration instructions in README.rst
  • Add step in README.rst to ensure /var/run/renderd exists

@hummeltech hummeltech force-pushed the TestInstallFromPackage branch from 0d5a18a to 6f25099 Compare August 1, 2023 14:25
@hummeltech hummeltech force-pushed the TestInstallFromPackage branch 2 times, most recently from 050d295 to 400fbf5 Compare September 29, 2023 14:02
@hummeltech hummeltech force-pushed the TestInstallFromPackage branch from fc7f0a4 to e2dc588 Compare October 3, 2023 21:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (184f143) 44.96% compared to head (d5dcb4c) 44.92%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   44.96%   44.92%   -0.05%     
==========================================
  Files          23       23              
  Lines        4577     4577              
==========================================
- Hits         2058     2056       -2     
- Misses       2519     2521       +2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hummeltech hummeltech force-pushed the TestInstallFromPackage branch 2 times, most recently from d5dcb4c to 70e94d7 Compare October 3, 2023 21:54
@hummeltech hummeltech force-pushed the TestInstallFromPackage branch from 70e94d7 to a8dffc9 Compare October 3, 2023 21:55
@hummeltech hummeltech merged commit 68e46a2 into openstreetmap:master Nov 28, 2023
@hummeltech hummeltech deleted the TestInstallFromPackage branch November 28, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants