-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List of user's changeset comments #4248
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should merge note comments under this interface eventually, and make the current user notes view just show notes they opened and not every comment - maybe as part of the planned restructuring of notes to make notes less linked to the initial comment.
We seem to have some existing work on this topic: #1642 |
@mmd-osm you have to look why #1642 failed. The reasons in its comments are:
|
b85d37b
to
5023a7f
Compare
Adding note comments here is an obvious extension, however adding note actions is not as obvious. Note comments are currently tied to actions such as closing and reopening. This is something that the planned restructuring completely ignores. If I close a note without writing anything, is it a comment that should be shown here? |
2f1337d
to
19fbc2f
Compare
7a1644c
to
3a00273
Compare
00d0de4
to
0f84169
Compare
9e7ac86
to
02d6e57
Compare
02d6e57
to
2dbb3eb
Compare
2dbb3eb
to
dcfe138
Compare
dcfe138
to
cd0d0d0
Compare
Add user's changeset comments next to user's diary comments.
Pagination is reused along with traces list.
Localization strings are mostly kept in diary comments section for now.