Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system font on error pages #5277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Collaborator

I opened #5131 and put a number of changes to error pages to see which of them are acceptable. The discussion there however has been about making more changes. I guess that means nobody objects to the ones I made and we can have them merged.

This PR changes the font of error pages to a default system ui font. Bootstrap does the same thing except also adds fallback fonts for older browsers that don't understand font-family: system-ui. We don't need a serif font for a text this short because we don't use serif fonts even for longer texts on the website.

Addresses this from #3532:

It also looks incredibly ugly, with loads of whitespace and the default browser font.

image

@tomhughes
Copy link
Member

My PR hasn't been merged in two months so it must be good is an interesting take.

That said I'm not totally sure why I didn't merge it - possibly I was concerned about adding so much custom CSS code which we are generally trying to avoid.

Is there a reason not to use bootstrap here?

@AntonKhorev
Copy link
Collaborator Author

My PR hasn't been merged in two months so it must be good is an interesting take.

How else can I get changes from that PR to be discussed instead of being asked to make more changes like:

Is there a reason not to use bootstrap here?

Yes #5130 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants