Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backfill note subscriptions #5304

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Backfill note subscriptions #5304

merged 1 commit into from
Nov 8, 2024

Conversation

AntonKhorev
Copy link
Collaborator

Part two of #5283.

Creates a subscription for every note commented by a non-anonymous user. Does this by:

  • iterating through batches of note comments
  • getting distinct non-null (user, note) pairs
  • inserting these pairs using upsert_all, this skips already existing pairs

@AntonKhorev AntonKhorev force-pushed the note-subscriptions-backfill branch from e1d3074 to c848a88 Compare November 8, 2024 07:31
@tomhughes
Copy link
Member

This looks good now, thanks.

@tomhughes tomhughes merged commit 7086038 into openstreetmap:master Nov 8, 2024
22 checks passed
@AntonKhorev AntonKhorev deleted the note-subscriptions-backfill branch November 8, 2024 08:26
@AntonKhorev AntonKhorev mentioned this pull request Nov 22, 2024
Closed
@gravitystorm gravitystorm mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhughes tomhughes tomhughes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonKhorev @tomhughes