-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show "node also part of ways" as nested lists on way pages #5317
base: master
Are you sure you want to change the base?
Show "node also part of ways" as nested lists on way pages #5317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my main question here is whether we should start these (mostly) expanded or whether they should all be collapsed? Starting them expanded does mean that you're using more vertical space and reducing what top level information can be seen initially?
4ddc758
to
900719c
Compare
About starting (not) expanded and vertical space: The first obvious thing that I came up this is to use roughly the same logic other But then I checked some actual ways in osm and looks like their nodes in most of the cases are members of one or two ways. Other cases are relatively rare. If I do what I described in the previous paragraph, I wouldn't have to collapse almost any I expect most of space wasted in this case:
Here's an example that has two such sequences with one more special node in between: The idea is then to collect every such sequence into one list element, and that's what #5355 does. |
900719c
to
f581934
Compare
Way pages have lists of nodes. Every way node can be shared with other ways, and if it is, then all of those ways are also listed. Currently it's done as "(part of ways ...)" phrases with ways listed using
to_sentence
. Those are cumbersome to deal with. You can never be sure about grammar in translations. Also it's more difficult to style because each way may or may not have an icon, there's a space reserved for that icon, that icon has to be positioned into that space probably with a bunch of pixel values. That's what #5080 does and that's one thing I don't like about it.In this PR I convert those phrases with inline icons into nested lists. After that icons are going to be located at the beginning of
<li>
s both for nested lists of ways and outer lists of nodes. This will make icons easier to position.Also fixes #1147. Inner lists of ways contain only unique ways to avoid #1147 (comment). The outer list of all nodes has details collapsed for any node that was already written (see node 2071 on screenshots below).
Before:
After: