Duplicated orphaned ScheduleRule when making a new profile based on existing one

[rwadhwa910]

I have imported a schedule from a library which has 12 different schedules within it. After getting imported each schedule creates a copy of its own schedule as shown in the image below.

OS APP 1.1.0
Windows 10

[macumber]

Can you attach the original OSM you imported @rwadhwa910 ? By import, do you mean you loaded the OSM as a library and dragged the schedule into your model from the library?

[jmarrec]

@rwadhwa910 ping.

[rwadhwa910]

@macumber I imported the osm file as a library and then drag the schedules that were there in the osm file.I am not sure whether I have that osm file with me as I was working on NREL computer at that time.

[macumber]

I'm not seeing this same behavior but I am seeing orphan schedule day objects created when you "Make a new profile based on" another schedule.

[jmarrec]

I can't see the duplicated stuff. I suspect user tried to load the same OSM as a library, and while editing the OSM tried to import from that "library".

As far as orphaned... There's a double clone happening between the OSApp and the SDK.

OpenStudioApplication/src/openstudio_lib/SchedulesTabController.cpp

Lines 121 to 134 in d115b03

	void SchedulesTabController::addRule(model::ScheduleRuleset& scheduleRuleset, UUID scheduleDayHandle) {
	boost::optional<model::ScheduleRule> rule;
	if (!scheduleDayHandle.isNull()) {
	boost::optional<model::ScheduleDay> scheduleDayToCopy = scheduleRuleset.model().getModelObject<model::ScheduleDay>(scheduleDayHandle);
	if (scheduleDayToCopy) {
	rule = model::ScheduleRule(scheduleRuleset, scheduleDayToCopy->clone().cast<model::ScheduleDay>());
	}
	}
	if (!rule) {
	rule = model::ScheduleRule(scheduleRuleset);
	rule->daySchedule().addValue(Time(1, 0), defaultStartingValue(rule->daySchedule()));
	}
	OS_ASSERT(rule);
	}

It's perhaps confusing but the SDK ctor ScheduleRule::ScheduleRule(ScheduleRuleset& scheduleRuleset, const ScheduleDay& daySchedule) actually clones daySchedule already internally...

https://github.com/NREL/OpenStudio/blob/92a416c03a98b44b67668e5b3d6d3c89be729afa/src/model/ScheduleRule.cpp#L600-L617

[jmarrec]

For the record, the same applies to Summer/Winter/holiday profiles... ScheduleRuleset::setXXXDesignDaySchedule ALSO clones the schedule day it's passed (which is confusing).

https://github.com/NREL/OpenStudio/blob/92a416c03a98b44b67668e5b3d6d3c89be729afa/src/model/ScheduleRuleset.cpp#L281-L307