FloorspaceJSON is corrupted on merge

[macumber]

Issue overview

Reported at https://unmethours.com/question/70492/floorspacejs-json-file-corrupted-after-merging-with-osm/

Current Behavior

FloorspaceJSON is corrupted during merge

Expected Behavior

Merge should not corrupt FloorspaceJSON

Context

Cannot continue working with model

[jmarrec]

We don't have enough information to reproduce (user didn't respond when asked for the files). With the direction things are going (use gltf), I'm closing. We can reopen if we get enough info to reproduce though.

[enrico-prataviera]

Hi,

I have the same issue reported here
Apparently, after merging the FloorspaceJS model with the osm model, the floorplan.json is corrupted and it is no more available in the editor tab.
Find attached the osm and the floorplan.json before and after the merging

I'm using Windows 10 Enterprise, Openstudio application 1.4.0, with the embedded FloorspaceJS
(not sure how to share the files)
ModelOSM.zip

[enrico-prataviera]

Update

I think I found the issue.
In the original file, I created a story called "Basement" and a space called "Basement" in FloorspaceJS.
Since similar names are not accepted, OS renamed the story "Basement 1" after the merging, but the name was not updated automatically in the floorspace.json. The name mismatch didn't allow the floorspace.json to be loaded correctly again.
Same issue with Attic story and space. Changing the name of the stories and spaces solved the issue.

Not sure if it is useful to add a check in floorspaceJS to automatically change the name of objects in case OS renames them.

[macumber]

That is a great clue to follow up on @enrico-prataviera, I will look into it!