Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 23, 2024

image

I suppose we should have a toggle switch somewhere in the preferences...

@macumber
Copy link
Collaborator

That looks great, I like a toggle but maybe on the tab itself?

@jmarrec
Copy link
Collaborator Author

jmarrec commented May 24, 2024

Theoretically speaking, this applies to space, surfaces, shading surfaces, thermal zones, etc etc.
A toggle on each of these subtabs would be a hassle no?

@jmarrec
Copy link
Collaborator Author

jmarrec commented May 24, 2024

I implemented a Preferences checkbox to display Additional Properties or not.

Currently applies to:

  • Any Spaces subtab
  • Any Facility subtab (except building, where it doesn't make much sense);
    • That includes for ShadingSurfaces I use a DataSource
  • The InspectorGadget

Please see this, and depending on whether this looks good or not, we can decide if we finish it up

612_displayAdditional_Props

Missing for completion:

  • Probably Space Type? ThermalZone ? Constructions?
  • Maybe a different IG layout for Additional Props... ideally you'd have a button to create the AdditionalProperties object if missing. And might want to be able to delete a feature group even if it's the middle.

@jmarrec jmarrec force-pushed the 612_displayName branch from 22e0ba8 to cf0272e Compare May 24, 2024 12:25
@jmarrec jmarrec force-pushed the 612_displayName branch from cf0272e to ea0e03d Compare May 24, 2024 12:27
m_verticalId = verticalId;

bool isIP = m_mainWindow->displayIP();
bool displayAdditionalProps = m_mainWindow->displayAdditionalProps();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does toggleDisplayAdditionalPropsClicked get emitted somewhere on startup if it is set?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's read from settings and passed around. I dont think it needs to be emitted

std::function<void(model::ShadingSurface*)>([](model::ShadingSurface* t_ss) { t_ss->remove(); })),
boost::optional<std::function<bool(model::ShadingSurface*)>>(), DataSource(allShadingSurfaces, true));
} else if (field == DISPLAYNAME) {
addLoadNameColumn(Heading(QString(DISPLAYNAME), false, false), // heading
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just addValueEditColumn would work here? Or addNameLineEditColumn? To show the value without the icon?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah probably. I'll look into it

@jmarrec jmarrec merged commit 43dd06b into develop Jul 15, 2024
@jmarrec jmarrec deleted the 612_displayName branch July 15, 2024 14:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
@jmarrec jmarrec changed the title #612 - Display Name #612 - Display Name and CAD Object ID Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show displayname in grid view

2 participants