Fix #708 - Improve SetpointManager views: support more types, add plots where applicable, and support PlantLoop #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jmarrec
commented
Aug 28, 2024
jmarrec
commented
- Fix Support more SetpointManager types on HVACSystemViews #708
…type if not explicitly supported instead of saying "Missing **or** unknown"
Collaborator
Author
|
@macumber Would need to install the "QtCharts" component on the mac-arm64. I can't do it with maintenancetool since it's linked to your Qt account and I can't change that and don't have the password. |
Collaborator
Author
|
@macumber do you need time to review or should I just drop this one in and do a RC package? |
macumber
approved these changes
Sep 2, 2024
Collaborator
macumber
left a comment
macumber
left a comment
There was a problem hiding this comment.
Nope I looked this over, no notes, it looks great!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.