Conversation
Collaborator
jmarrec
commented
Sep 5, 2024
jmarrec
commented
- Fix [v1.8.0-rc3] Opening Shoebox Model several times in a row produces a crash #747 (hopefully)
- Fix a crash when you try to load the Shoebox model from the Workflow/Measures tab
Collaborator
Author
|
cannot reproduce crash on macOs either |
macumber
reviewed
Sep 6, 2024
| boost::optional<openstudio::model::Model> model = versionTranslator.loadModel(filePath); | ||
| if (!model && isOpenStudioApplicationRunningFromBuildDirectory()) { | ||
| boost::optional<openstudio::model::Model> model_; | ||
| if (openstudio::filesystem::is_regular_file(filePath)) { |
Collaborator
There was a problem hiding this comment.
Was this the line that prevents the crash? Or one of the lines below checking that currentDocument is not null?
Collaborator
Author
There was a problem hiding this comment.
currentDocument not null.
Collaborator
Author
There was a problem hiding this comment.
This specific change is mostly because I found it annoying and counterproductive to try to load a model and get a warning/error on the console like "Cannot resolve path 'xxxx', model can't be loaded".
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.