Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Oct 9, 2024

My two cents: NEVER USE special characters for files or directory names. Nor space.

Limit all file names to numbers ([0-9]) letters ([a-zA-Z]), and "-", "_" and "." You'll live a a much happier life generally.

My two cents: NEVER USE special characters for files or directory names. Nor space.
Limit all file names to numbers ([0-9]) letters ([a-zA-Z]), and "-", "_" and "."
You'll live a a much happier life generally.
QString fullPathString = toQString(report);

QFile file(fullPathString);
fullPathString.prepend("file:///");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for that

Copy link
Collaborator

@macumber macumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jmarrec jmarrec merged commit 20695ee into develop Oct 14, 2024
@jmarrec jmarrec deleted the 758_results_url branch October 14, 2024 07:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants