Fix #792 - Add support for HotWaterEquipment and HotWaterEquipmentDefinition#793
Merged
Fix #792 - Add support for HotWaterEquipment and HotWaterEquipmentDefinition#793
Conversation
Collaborator
jmarrec
commented
Feb 27, 2025
jmarrec
commented
- Fix Add support for HotWaterEquipment and HotWaterEquipmentDefinition #792
jmarrec
commented
Feb 27, 2025
src/openstudio_lib/images/mini_icons/hotwater_equipment_definition@2x.png
Show resolved
Hide resolved
jmarrec
commented
Feb 27, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for HotWaterEquipment and HotWaterEquipmentDefinition by updating test cases, controller logic, icon mappings, and the user interface inspector views.
- Added HotWaterEquipment and HotWaterEquipmentDefinition to the test suite and icon library.
- Updated LoadsView and LoadsController to handle the new equipment definition.
- Introduced a new HotWaterEquipmentInspectorView for detailed inspection of Hot Water Equipment definitions.
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/openstudio_lib/test/IconLibrary_GTest.cpp | Added test cases for the HotWater equipment types. |
| src/openstudio_lib/LoadsView.hpp | Declared a new inspector method for HotWaterEquipment definitions. |
| src/openstudio_lib/LoadsView.cpp | Updated type mappings and logic to display HotWaterEquipment inspectors. |
| src/openstudio_lib/LoadsController.cpp | Added a new case to create HotWaterEquipmentDefinition objects. |
| src/openstudio_lib/IconLibrary.cpp | Added icon mappings for HotWaterEquipment and its definition. |
| src/openstudio_lib/HotWaterEquipmentInspectorView.hpp | Added declaration for the new inspector view. |
| src/openstudio_lib/HotWaterEquipmentInspectorView.cpp | Implemented the new inspector view with bindings for UI elements. |
Files not reviewed (2)
- src/openstudio_lib/CMakeLists.txt: Language not supported
- src/openstudio_lib/openstudio.qrc: Language not supported
jmarrec
force-pushed
the
792-HotWaterEquipment
branch
from
b5e439b to
75d0dbf
Compare
jmarrec
force-pushed
the
792-HotWaterEquipment
branch
from
75d0dbf to
4357a24
Compare
macumber
approved these changes
Jul 3, 2025
Collaborator
macumber
left a comment
macumber
left a comment
There was a problem hiding this comment.
Looks good, I think we can bypass CI checks on Mac since that is just an issue with code signing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.