Issue #166 - Sort measures alphabetically in GUI #795

antonszilasi · 2025-03-10T03:16:21Z

No description provided.

src/shared_gui_components/BuildingComponentDialogCentralWidget.cpp

antonszilasi · 2025-03-10T03:42:36Z

src/shared_gui_components/BuildingComponentDialogCentralWidget.cpp

….cpp Co-authored-by: Dan Macumber <dan.macumber@gmail.com>

…rType or tid has changed

+ // std::sort(responses.begin(), responses.end(), [](const BCLSearchResult& a, const BCLSearchResult& b) { + // return a.name() < b.name(); + // });

antonszilasi · 2025-04-24T01:15:50Z

This video is still current

src/shared_gui_components/BuildingComponentDialogCentralWidget.cpp

Copilot

Pull Request Overview

This PR addresses Issue #166 by updating the GUI to display measures in alphabetical order. Key changes include:

Adding a new function fetchAndSortResponses to retrieve and sort responses from the remote BCL.
Introducing an overall response cache (m_allResponses) and pagination logic within setTid.
Refactoring the setTid method to refresh responses only if the filter and search criteria change.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/shared_gui_components/BuildingComponentDialogCentralWidget.hpp	Added include and declarations for the new response fetching and caching mechanism.
src/shared_gui_components/BuildingComponentDialogCentralWidget.cpp	Implemented fetching, sorting, and pagination of responses; updated setTid to use the new method.

src/shared_gui_components/BuildingComponentDialogCentralWidget.hpp

src/shared_gui_components/BuildingComponentDialogCentralWidget.cpp

jmarrec · 2025-07-04T07:55:11Z

src/shared_gui_components/BuildingComponentDialogCentralWidget.cpp

+  if (!responses.empty()) {
+    std::sort(responses.begin(), responses.end(), [](const BCLSearchResult& a, const BCLSearchResult& b) {
+      return a.name() < b.name();
+    });
+  }


If I'm following correctly, you just factored a bit of code into a function, and added this bit that sorts the results.

Side note: the if (!responses.empty()) is not technically needed and does not make it faster. https://quick-bench.com/q/5lPbGyQNKctVRq7IdoD_fUVTPt4

(Running it a bunch of times locally produces results where one is sometimes faster than the other, so they're the same).

----------------------------------------------------------- Benchmark Time CPU Iterations ----------------------------------------------------------- SortNoIf_Items 4732 ns 4730 ns 147972 SortWithIf_Items 5040 ns 5038 ns 138705

antonszilasi added 2 commits March 9, 2025 22:12

Checkpoint sort measures alphabetically

934e973

Update BuildingComponentDialogCentralWidget.cpp

4a50fb7

antonszilasi commented Mar 10, 2025

View reviewed changes

src/shared_gui_components/BuildingComponentDialogCentralWidget.cpp Show resolved Hide resolved

antonszilasi commented Mar 10, 2025

View reviewed changes

src/shared_gui_components/BuildingComponentDialogCentralWidget.cpp Show resolved Hide resolved

Update BuildingComponentDialogCentralWidget.cpp

77398d3

antonszilasi commented Mar 10, 2025

View reviewed changes

src/shared_gui_components/BuildingComponentDialogCentralWidget.cpp Show resolved Hide resolved

antonszilasi changed the title ~~Checkpoint sort measures alphabetically~~ Issue #166 - Sort measures alphabetically in GUI Mar 10, 2025