Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Mar 10, 2025

@jmarrec jmarrec added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Minor Bug 🐤 component - UI labels Mar 10, 2025
@jmarrec jmarrec self-assigned this Mar 10, 2025
@jmarrec jmarrec requested a review from Copilot April 24, 2025 12:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #796 by adding support for Schedule File objects in the MainRightColumnController.

  • Adds Schedule File type entries to model and library lists in several sub-tab configuration functions (Schedules, Loads, SpaceTypes, Facility, Spaces, ThermalZones, and HVACSystems).
  • Ensures that Schedule File objects are available in the user interface for consistent object type handling.
Comments suppressed due to low confidence (1)

src/openstudio_lib/MainRightColumnController.cpp:248

  • [nitpick] Consider extracting the repeated addition of the 'Schedule File' object type into a helper function or constant to improve maintainability and reduce code duplication across the different configuration methods.
myModelList->addModelObjectType(IddObjectType::OS_Schedule_File, "Schedule File");

@jmarrec jmarrec merged commit ddaa51e into develop Jun 13, 2025
8 of 10 checks passed
@jmarrec jmarrec deleted the 796-ScheduleFile_MainRightCC branch June 13, 2025 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

component - UI Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Minor Bug 🐤

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ScheduleFile entries in My Model for tabs where missing (eg: Loads)

1 participant