Skip to content

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jul 7, 2025

@macumber
Copy link
Collaborator

macumber commented Jul 10, 2025

Looks good, seems like there is no reason to be able to delete the object, this will trigger an update when opening an OSM that doesn't have the object but that is not a big deal.

The only real use I saw for this is changing the output of Output:Table:ReportPeriod, is that being added to the StandardReport measure? Should we update https://github.com/openstudiocoalition/openstudio-coalition-measures/tree/main/models/ShoeboxExample/measures/openstudio_results which is where the default results measure comes from? FYI, this is where it gets pulled in: https://github.com/openstudiocoalition/OpenStudioApplication/blob/develop/CMakeLists.txt#L665

We should update the OSM versions in that repo too (and add that to the steps when releasing a new version, I had forgotten about it...)

@jmarrec
Copy link
Collaborator Author

jmarrec commented Jul 11, 2025

I will affect the ThermalResilienceSummary too. There is no need to update openstudio_results.
I don't expect people to actually use that object much, but anyways it does NOT change the structure of the table, it just changes how the Zone Heat Index is calculated.

@jmarrec jmarrec merged commit bdc7665 into develop Jul 11, 2025
10 checks passed
@jmarrec jmarrec deleted the 815_OutputControl_ResilienceSummaries branch July 11, 2025 08:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OS SDK 3.10.0] Add OutputControl:ResilienceSummaries

2 participants