Skip to content

Future proof pinging bcl.nlr.gov instead of bcl.nrel.gov #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmarrec wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Future proof pinging bcl.nlr.gov instead of bcl.nrel.gov #856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/shared_gui_components/NetworkProxyDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,10 @@ std::pair<QNetworkReply::NetworkError, QString> NetworkProxyDialog::testProxyCon
QNetworkReply* head = nam.head(QNetworkRequest(QUrl("https://bcl.nrel.gov/")));

if (!head) {
return std::make_pair(QNetworkReply::UnknownNetworkError, QString("Unknown error creating connection to proxy."));
QNetworkReply* head = nam.head(QNetworkRequest(QUrl("https://bcl.nlr.gov/")));
if (!head) {
return std::make_pair(QNetworkReply::UnknownNetworkError, QString("Unknown error creating connection to proxy."));
}
Comment on lines 131 to +137
Copy link
Collaborator Author

@jmarrec jmarrec Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bcl.nrel.gov will be gone soon, but right now bcl.nlr.gov doesn't exist yet, so just test both.

This only happens when testing proxy connection, which I guess not a lot of people use anyways.

Copy link
Collaborator

@macumber macumber Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a good idea. Ideally, we could make the BCL URL configurable and guess a smart default for the whole app like this. However, it looks like there isn't really a good way to configure the URL in https://github.com/NatLabRockies/OpenStudio/blob/develop/src/utilities/bcl/RemoteBCL.cpp.

Copy link
Collaborator Author

@jmarrec jmarrec Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the OS SDK is what really queries the BCL. If bcl.nrel.gov were to disappear, every known version of the OS SDK until 3.11.0 included would no longer be able to connect to the BCL, so I do hope there's going to be a DNS redirection for the foreseeable future.

}

boost::posix_time::ptime start = boost::posix_time::microsec_clock::universal_time();
Expand Down
Loading