feat: support property ThemeColor id

opensumi · Jan 3, 2025 · 24a8e8d · 24a8e8d
1 parent 7b8b351
commit 24a8e8d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/extension/src/common/vscode/ext-types.ts b/packages/extension/src/common/vscode/ext-types.ts
@@ -991,7 +991,7 @@ export enum TextEditorLineNumbersStyle {
 
 @es5ClassCompat
 export class ThemeColor {
-  id: string;
+  readonly id: string;
   constructor(id: string) {
     this.id = id;
   }

diff --git a/packages/extension/src/hosted/api/vscode/ext.host.statusbar.ts b/packages/extension/src/hosted/api/vscode/ext.host.statusbar.ts
@@ -79,7 +79,7 @@ export class StatusBarItemImpl implements vscode.StatusBarItem {
   private _tooltip?: string | vscode.MarkdownString;
   private _name?: string;
   private _color: string | ThemeColor | undefined;
-  private _backgroundColor: string | ThemeColor | undefined;
+  private _backgroundColor: ThemeColor | undefined;
   private _command: string | vscode.Command | undefined;
 
   private _isVisible: boolean;
@@ -148,11 +148,11 @@ export class StatusBarItemImpl implements vscode.StatusBarItem {
     this.update();
   }
 
-  public get backgroundColor(): string | ThemeColor | undefined {
+  public get backgroundColor(): ThemeColor | undefined {
     return this._backgroundColor;
   }
 
-  public set backgroundColor(color: string | ThemeColor | undefined) {
+  public set backgroundColor(color: ThemeColor | undefined) {
     if (!color) {
       color = undefined;
     } else if (isString(color)) {

diff --git a/packages/types/vscode/typings/vscode.theme.d.ts b/packages/types/vscode/typings/vscode.theme.d.ts
@@ -4,6 +4,11 @@ declare module 'vscode' {
    * Using a theme color is preferred over a custom color as it gives theme authors and users the possibility to change the color.
    */
   export class ThemeColor {
+    /**
+     * The id of this color.
+     */
+    readonly id: string;
+
     /**
      * Creates a reference to a theme color.
      * @param id of the color. The available colors are listed in https://code.visualstudio.com/docs/getstarted/theme-color-reference.