fix: trigger suggest correctly while open settings.json

opensumi · Apr 21, 2022 · 88042cb · 88042cb
1 parent 11a8201
commit 88042cb
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/preferences/src/browser/preference-contribution.ts b/packages/preferences/src/browser/preference-contribution.ts
@@ -193,13 +193,13 @@ export class PreferenceContribution
     });
 
     commands.registerCommand(PREFERENCE_COMMANDS.OPEN_USER_SETTING_FILE, {
-      execute: async () => {
+      execute: () => {
         this.openResource(PreferenceScope.User);
       },
     });
 
     commands.registerCommand(PREFERENCE_COMMANDS.OPEN_WORKSPACE_SETTING_FILE, {
-      execute: async () => {
+      execute: () => {
         this.openResource(PreferenceScope.Workspace);
       },
     });
@@ -315,11 +315,15 @@ export class PreferenceContribution
     }
   }
 
-  async openResource(scope?: PreferenceScope, preferenceId?: string) {
+  async openResource(scope?: PreferenceScope, preferenceId?: string, groupIndex?: number) {
     const url = await this.preferenceService.getCurrentPreferenceUrl(scope);
     const openResult = await this.commandService.executeCommand<IResourceOpenResult>(
       EDITOR_COMMANDS.OPEN_RESOURCE.id,
       new URI(url),
+      {
+        focus: true,
+        groupIndex: this.workbenchEditorService.currentEditorGroup.index,
+      },
     );
     if (openResult && preferenceId) {
       const editor = this.workbenchEditorService.editorGroups.find((g) => g.name === openResult.groupId)?.currentEditor;