Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing breadcrumb #1013

Merged
merged 3 commits into from
May 13, 2022
Merged

Conversation

iamxukai
Copy link
Contributor

@iamxukai iamxukai commented May 11, 2022

Types

  • 🐛 Bug Fixes
  • 🧹 Chores

Background or solution

closes #905
closes #992

Changelog

  1. add missing breadcrumb
  2. unify scheme file and scheme user storage

@iamxukai iamxukai changed the title fix: add missing breadcrumb WIP: add missing breadcrumb May 11, 2022
@iamxukai iamxukai changed the title WIP: add missing breadcrumb fix: add missing breadcrumb May 12, 2022
@iamxukai iamxukai requested a review from erha19 May 12, 2022 04:49
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1013 (9d282c0) into main (c681e8d) will decrease coverage by 0.00%.
The diff coverage is 68.68%.

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   58.50%   58.50%   -0.01%     
==========================================
  Files        1225     1225              
  Lines       75546    75542       -4     
  Branches    15705    15709       +4     
==========================================
- Hits        44201    44196       -5     
- Misses      28572    28573       +1     
  Partials     2773     2773              
Flag Coverage Δ
jsdom 49.38% <62.62%> (-0.01%) ⬇️
node 25.91% <31.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/browser/vscode/api/main.thread.api.webview.ts 29.49% <0.00%> (ø)
...xtension/src/browser/vscode/api/main.thread.doc.ts 62.02% <ø> (-0.24%) ⬇️
packages/extension/src/common/vscode/ext-types.ts 50.40% <ø> (-0.08%) ⬇️
...sion/src/hosted/api/vscode/ext.host.api.webview.ts 70.50% <0.00%> (ø)
packages/file-scheme/src/common/index.ts 100.00% <ø> (ø)
packages/file-service/src/common/files.ts 86.84% <ø> (-0.34%) ⬇️
packages/markdown/src/browser/contribution.ts 0.00% <0.00%> (ø)
...ackages/output/src/browser/output-link.provider.ts 0.00% <0.00%> (ø)
packages/preferences/src/common/user-storage.ts 100.00% <ø> (ø)
packages/search/src/browser/search-tree.service.ts 36.27% <0.00%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c681e8d...9d282c0. Read the comment docs.

@erha19 erha19 merged commit 9af5e4f into opensumi:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants