fix: set default language #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
erha19
requested changes
May 18, 2023
limerickgds
force-pushed
the
fix/set-default-language
branch
from
b3f6811 to
71a68ae
Compare
|
/next |
limerickgds
force-pushed
the
fix/set-default-language
branch
from
71a68ae to
53b15cc
Compare
|
🎉 PR Next version 2.24.3-next-1684376157.0 publish successful! You can install this version via |
erha19
previously approved these changes
May 24, 2023
|
@erha19 这个下个版本会合并吗？ |
|
@limerickgds 会的，CI 还有问题，等通过了会合并 |
|
@limerickgds 这个测试需要修一下 |
limerickgds
force-pushed
the
fix/set-default-language
branch
from
53b15cc to
c67d5f6
Compare
|
@limerickgds 还是不对，这里是 |
limerickgds
force-pushed
the
fix/set-default-language
branch
from
c67d5f6 to
fc55851
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2722 +/- ##
==========================================
- Coverage 57.72% 57.68% -0.05%
==========================================
Files 1327 1333 +6
Lines 83563 83846 +283
Branches 17381 17432 +51
==========================================
+ Hits 48238 48366 +128
- Misses 32104 32249 +145
- Partials 3221 3231 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖 Generated by Copilot at b3f6811
getPreferenceLanguageIdfunction (link)close #2713
Changelog
🤖 Generated by Copilot at b3f6811
Fixed a bug in
core-browserthat caused the user's language preference to be ignored. ModifiedgetPreferenceLanguageIdto compare the scope of the external and default preferences.