Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto open tab when expend bottom #2800

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

AhkunTa
Copy link
Member

@AhkunTa AhkunTa commented Jun 12, 2023

Types

  • 🐛 Bug Fixes

Background or solution

  • auto open tab when expend bottom
2023-06-13.09.54.32.mov

🤖 Generated by Copilot at f753b50

  • Ensure that the current tab container id is always defined (link) in layout.service.ts

Changelog

🤖 Generated by Copilot at f753b50

Fix errors when switching tabs or layouts by ensuring tabbarService.currentContainerId is always defined. Update layout.service.ts to assign it to the first available container id if it is falsy.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (4033de3) 57.69% compared to head (f753b50) 57.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.25    #2800      +/-   ##
==========================================
- Coverage   57.69%   57.67%   -0.02%     
==========================================
  Files        1336     1336              
  Lines       83866    83871       +5     
  Branches    17432    17436       +4     
==========================================
- Hits        48388    48376      -12     
- Misses      32248    32262      +14     
- Partials     3230     3233       +3     
Flag Coverage Δ
jsdom 52.69% <0.00%> (-0.02%) ⬇️
node 16.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/main-layout/src/browser/layout.service.ts 61.20% <0.00%> (-1.11%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AhkunTa AhkunTa requested a review from Ricbet June 13, 2023 01:59
@AhkunTa AhkunTa merged commit abb9673 into v2.25 Jun 13, 2023
@AhkunTa AhkunTa deleted the fix/expand-bottom-when-hide-tabbar branch June 13, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants