Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: change resize handler z-index #2868

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jul 5, 2023

Types

  • 💄 Style Changes

Background or solution

🤖 Generated by Copilot at f1fc1d1

  • Increase z-index of horizontal and vertical resize handles to ensure visibility and accessibility (link)
  • Remove z-index of diagonal resize handle to avoid conflicts and make consistent with other handles (link)
  • Remove z-index of resize container to avoid conflicts and make consistent with other elements (link)

Before:
image
image

默认的 sticky-widget 层级为 11,会盖住默认拖动条

After:
image

Changelog

🤖 Generated by Copilot at f1fc1d1

This pull request enhances the resize component in core-browser by fixing some z-index issues and making the handles more consistent.

@opensumi opensumi bot added 💄 style change 🐞 bug Something isn't working labels Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (86d94ed) 57.62% compared to head (f1fc1d1) 57.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2868      +/-   ##
==========================================
- Coverage   57.62%   57.62%   -0.01%     
==========================================
  Files        1336     1336              
  Lines       84013    84013              
  Branches    17465    17465              
==========================================
- Hits        48412    48411       -1     
- Misses      32357    32358       +1     
  Partials     3244     3244              
Flag Coverage Δ
jsdom 52.65% <ø> (-0.01%) ⬇️
node 16.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet Ricbet merged commit 40e0518 into main Jul 13, 2023
@Ricbet Ricbet deleted the style/change-resize-handle-z-index branch July 13, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💄 style change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants