Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: worker api not execute #2879

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix: worker api not execute #2879

merged 1 commit into from
Jul 13, 2023

Conversation

AhkunTa
Copy link
Member

@AhkunTa AhkunTa commented Jul 11, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖 Generated by Copilot at 0737384

  • Remove deprecated commands property from API factory object (link)
  • Refactor sumiAPI property to a function that takes extension as argument and returns custom APIs (link)

Changelog

🤖 Generated by Copilot at 0737384

This pull request updates the API factory object for extensions in worker.host.api.impl.ts to use the latest VS Code API and enhance the Sumi APIs. It removes the unused commands property and refactors the sumiAPI property.

@opensumi opensumi bot added 🐞 bug Something isn't working ⚙️ refactor Refactor code labels Jul 11, 2023
@AhkunTa AhkunTa changed the base branch from v2.25 to main July 11, 2023 07:07
@AhkunTa AhkunTa changed the title fix: worker api not execute WIP fix: worker api not execute Jul 11, 2023
@AhkunTa AhkunTa changed the title WIP fix: worker api not execute fix: worker api not execute Jul 11, 2023
@AhkunTa
Copy link
Member Author

AhkunTa commented Jul 11, 2023

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jul 11, 2023

🎉 PR Next version 2.25.4-next-1689059890.0 publish successful! You can install this version via npm install package@2.25.4-next-1689059890.0

2.25.4-next-1689059890.0

@AhkunTa AhkunTa requested a review from Ricbet July 11, 2023 07:56
Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ricbet Ricbet merged commit d71f3a1 into main Jul 13, 2023
@Ricbet Ricbet deleted the fix/worker-api branch July 13, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants