Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: design menubar toolbar actions #4268

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Dec 25, 2024

Types

  • 🎉 New Features

Background or solution

Changelog

design menubar 支持插件注册的 toolbar

Summary by CodeRabbit

  • 新功能
    • 在菜单栏右侧新增了工具栏组件,增强了用户界面的功能。
  • 依赖更新
    • 添加了对 @opensumi/ide-toolbar 的依赖。

@Ricbet Ricbet self-assigned this Dec 25, 2024
@Ricbet Ricbet linked an issue Dec 25, 2024 that may be closed by this pull request
@opensumi opensumi bot added the 🎨 feature feature required label Dec 25, 2024
Copy link
Contributor

coderabbitai bot commented Dec 25, 2024

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

变更概述

演练

此变更在菜单栏视图中引入了 ToolBar 组件。具体而言,在 DesignMenuBarView 函数中,从 @opensumi/ide-toolbar/lib/browser/toolbar.view 模块导入 ToolBar 组件,并将其添加到菜单栏右侧区域。这一新增提供了一个额外的用户界面元素,扩展了菜单栏的功能。

变更

文件路径 变更描述
packages/design/src/browser/menu-bar/menu-bar.view.tsx 新增 ToolBar 组件导入并在菜单栏右侧区域渲染
packages/design/package.json 新增依赖项 "@opensumi/ide-toolbar": "workspace:*"

可能相关的 PR

建议的审阅者

  • bk1012
  • hacke2

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 72e0284 and 87642a7.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • packages/design/package.json (1 hunks)
  • packages/design/src/browser/menu-bar/menu-bar.view.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/design/src/browser/menu-bar/menu-bar.view.tsx
🔇 Additional comments (1)
packages/design/package.json (1)

29-30: 依赖项添加正确且符合规范!

新增的 @opensumi/ide-toolbar 依赖项与现有依赖保持一致的版本格式(workspace:*),且放置位置合理。这个改动与PR的菜单栏工具栏功能需求相符。

验证工具栏包的存在性:

✅ Verification successful

依赖项添加验证通过!

@opensumi/ide-toolbar 包确实存在于工作区中,且为有效的内部包。该包位于 packages/toolbar 目录下,具有完整的 package.json 配置。依赖引用格式 workspace:* 与仓库中其他内部依赖的使用方式保持一致。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: 验证 ide-toolbar 包是否存在于工作区
# 预期结果:在 packages 目录下找到 toolbar 包

fd -t d "toolbar" packages/

Length of output: 220


Script:

#!/bin/bash
# Verify if the package.json exists in the toolbar package
cat packages/toolbar/package.json

Length of output: 629


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.28%. Comparing base (ec1561f) to head (87642a7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4268   +/-   ##
=======================================
  Coverage   54.27%   54.28%           
=======================================
  Files        1633     1633           
  Lines       99712    99717    +5     
  Branches    21636    21639    +3     
=======================================
+ Hits        54123    54127    +4     
- Misses      37880    37881    +1     
  Partials     7709     7709           
Flag Coverage Δ
jsdom 49.80% <ø> (+<0.01%) ⬆️
node 12.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet Ricbet force-pushed the fix/design-menu-bar-toolbar branch from 72e0284 to 87642a7 Compare December 25, 2024 06:03
Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hacke2 hacke2 merged commit 1a08936 into main Dec 25, 2024
12 checks passed
@hacke2 hacke2 deleted the fix/design-menu-bar-toolbar branch December 25, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 插件通过kaitianContributes注册到toolbar上不生效
2 participants