-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: design menubar toolbar actions #4268
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options. 变更概述演练此变更在菜单栏视图中引入了 变更
可能相关的 PR
建议的审阅者
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)packages/design/package.json (1)
新增的 验证工具栏包的存在性: ✅ Verification successful依赖项添加验证通过!
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: 验证 ide-toolbar 包是否存在于工作区
# 预期结果:在 packages 目录下找到 toolbar 包
fd -t d "toolbar" packages/
Length of output: 220 Script: #!/bin/bash
# Verify if the package.json exists in the toolbar package
cat packages/toolbar/package.json
Length of output: 629 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4268 +/- ##
=======================================
Coverage 54.27% 54.28%
=======================================
Files 1633 1633
Lines 99712 99717 +5
Branches 21636 21639 +3
=======================================
+ Hits 54123 54127 +4
- Misses 37880 37881 +1
Partials 7709 7709
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
72e0284
to
87642a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types
Background or solution
Changelog
design menubar 支持插件注册的 toolbar
Summary by CodeRabbit
@opensumi/ide-toolbar
的依赖。