Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust the scope of the diffEditor.hideUnchangedRegions.enabled configuration to the user level #4270

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

hacke2
Copy link
Member

@hacke2 hacke2 commented Dec 25, 2024

fix: adjust the scope of the diffEditor.hideUnchangedRegions.enabled configuration to the user level

Types

  • 🪚 Refactors

Background or solution

Changelog

fix: adjust the scope of the diffEditor.hideUnchangedRegions.enabled configuration to the user level

Summary by CodeRabbit

  • 新功能
    • 增加了用户范围的偏好设置选项,允许用户自定义“隐藏未更改区域”功能。

@hacke2 hacke2 requested a review from erha19 December 25, 2024 03:35
@opensumi opensumi bot added the 🐞 bug Something isn't working label Dec 25, 2024
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

coderabbitai bot commented Dec 25, 2024

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

变更概述

步骤概览

此次变更修改了比较编辑器贡献类中的偏好设置设置方法。具体而言,在切换 diffEditor.hideUnchangedRegions.enabled 偏好设置时,新增了 PreferenceScope.User 作为第三个参数,明确指定了偏好设置的作用域为用户级别。

变更

文件路径 变更说明
packages/editor/src/browser/diff/compare.ts CompareEditorContribution 类的 registerCommands 方法中,this.preferenceService.set 调用新增 PreferenceScope.User 参数

可能相关的 PR

建议的审阅者

  • Ricbet

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec1561f and c06a6c5.

📒 Files selected for processing (1)
  • packages/editor/src/browser/diff/compare.ts (2 hunks)
🔇 Additional comments (2)
packages/editor/src/browser/diff/compare.ts (2)

10-10: 引入 PreferenceScope 很合理,对后续指定用户级别配置非常必要。
这个改动很好地满足了将配置项调整至用户级别的需求,便于个性化定制。


113-113: 设置 PreferenceScope.User 完全符合 PR 目标,建议测试一下用户级配置变化是否生效。
此处将 diffEditor.hideUnchangedRegions.enabled 的配置范围从默认改为用户级,可使不同用户独立管理各自的 Diff 编辑偏好。为避免回归或潜在的覆盖问题,建议补充测试用例或校验逻辑以确认用户级设置正常工作。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.27%. Comparing base (89c4fea) to head (c06a6c5).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/editor/src/browser/diff/compare.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4270      +/-   ##
==========================================
+ Coverage   53.72%   54.27%   +0.55%     
==========================================
  Files        1622     1633      +11     
  Lines       98572    99712    +1140     
  Branches    20143    21636    +1493     
==========================================
+ Hits        52955    54123    +1168     
+ Misses      37911    37880      -31     
- Partials     7706     7709       +3     
Flag Coverage Δ
jsdom 49.80% <0.00%> (+0.60%) ⬆️
node 12.27% <0.00%> (-3.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet Ricbet merged commit df8a7e6 into main Dec 25, 2024
14 checks passed
@Ricbet Ricbet deleted the fix/hideUnchangedRegions-scope branch December 25, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants