chore: revert incorrect prop name in Modal component

[erha19]

Types

• 🧹 Chores

Background or solution

Changelog

revert incorrect prop name in Modal component

Summary by CodeRabbit

• 样式调整
  • 修改了模态框组件的类名传递方式，可能会影响模态框的视觉呈现。

[erha19]

/next

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

概述

浏览

这个变更修改了 Modal 组件中 renderModal 方法的类名传递方式。具体而言，原本传递给 Dialog 组件的 className 属性被替换为 wrapClassName。这一变更可能会影响模态框的样式和布局，但未改变组件的核心渲染逻辑。

变更

文件路径	变更描述
packages/components/src/modal/Modal.tsx	将 Dialog 组件的 className 属性替换为 wrapClassName

序列图

由于变更仅涉及属性传递，未引入新的功能流程，因此不生成序列图。

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e6a03c and 401f98e.

📒 Files selected for processing (1)

• packages/components/src/modal/Modal.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: 🚀🚀🚀 Next Version for pull request
• GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
• GitHub Check: unittest (ubuntu-latest, 18.x, node)
• GitHub Check: build (ubuntu-latest, 20.x)
• GitHub Check: build-windows
• GitHub Check: unittest (macos-latest, 18.x, jsdom)
• GitHub Check: build (macos-latest, 20.x)
• GitHub Check: unittest (macos-latest, 18.x, node)
• GitHub Check: ubuntu-latest, Node.js 20.x

🔇 Additional comments (1)

packages/components/src/modal/Modal.tsx (1)

236-236: 正确修复了包裹元素的类名属性

将 className 改为 wrapClassName 是正确的，因为：

1. wrapClassName 属性专门用于设置对话框外层包裹元素的类名
2. 这与 rc-dialog 组件的 API 设计保持一致

让我们验证一下 rc-dialog 的 API 使用是否正确：

✅ Verification successful

确认 wrapClassName 属性使用正确

经过验证，wrapClassName 的使用完全符合 rc-dialog@9.6.0 的 API 规范。代码中正确处理了类名的组合，包括居中样式的条件应用。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 描述：验证 rc-dialog 组件的 wrapClassName 属性使用
# 预期：确认 rc-dialog 组件确实支持 wrapClassName 属性

# 搜索项目中 rc-dialog 的类型定义或使用示例
rg -t typescript "wrapClassName.*Dialog" --glob "!packages/components/src/modal/Modal.tsx"

Length of output: 127

---

Script:

#!/bin/bash
# Search for Dialog imports and rc-dialog usage
rg "from 'rc-dialog'" -A 2

# Search for wrapClassName usage in the codebase
rg "wrapClassName" --type-add "ts:*.{ts,tsx}" --type ts

# Check package.json for rc-dialog version
fd "package.json" --exec grep -l "rc-dialog" {} \; --exec cat {}

Length of output: 2348

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[opensumi]

🎉 PR Next publish successful!

3.7.1-next-1736320460.0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.20%. Comparing base (2e6a03c) to head (401f98e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4311   +/-   ##
=======================================
  Coverage   54.20%   54.20%           
=======================================
  Files        1634     1634           
  Lines       99941    99941           
  Branches    21695    21703    +8     
=======================================
  Hits        54178    54178           
  Misses      38020    38020           
  Partials     7743     7743           

Flag	Coverage Δ
jsdom	49.74% <ø> (ø)
node	12.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.