feat: make terminal draggable

[Marckon]

Types

• 🎉 New Features
• 🐛 Bug Fixes
• 📚 Documentation Changes
• 💄 Code Style Changes
• 💄 Style Changes
• 🪚 Refactors
• 🚀 Performance Improvements
• 🏗️ Build System
• ⏱ Tests
• 🧹 Chores
• Other Changes

Background or solution

Changelog

Summary by CodeRabbit

• 新功能

  • 为布局系统添加拖放容器功能
  • 为终端组件引入可拖动选项
  • 新增右侧和底部拖放区域

• 改进

  • 优化标签栏服务交互
  • 增强布局管理服务的灵活性
  • 改进容器和标签栏的渲染逻辑

• 样式调整

  • 更新布局和终端组件的样式
  • 新增样式类以支持拖放功能

• 技术优化

  • 重构布局服务方法
  • 改进容器管理和交互机制

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

概述

演练

这个拉取请求引入了一系列与布局和拖放功能相关的增强。主要变更包括在不同模块中添加新的 CSS 类、组件和服务方法，以支持容器的可拖动性和更灵活的布局管理。新增了右侧和底部的放置区域组件，并扩展了标签栏服务和布局服务的功能，使得组件可以在不同位置之间移动和重新排列。

变更

文件路径	变更摘要
packages/ai-native/src/browser/layout/layout.module.less	新增 .header CSS 类
packages/ai-native/src/browser/layout/tabbar.view.tsx	更新 ContainerViewFn 以支持自定义标题栏
packages/core-browser/src/layout/layout.interface.ts	添加 draggable 可选属性到 ExtViewContainerOptions 接口
packages/main-layout/src/browser/accordion/titlebar.view.tsx	扩展 TitleBar 组件以支持可拖动性
packages/main-layout/src/browser/default-config.ts	更新布局配置以包含新模块
packages/main-layout/src/browser/drop-area/drop-area.tsx	新增 DropArea 组件及相关逻辑
packages/main-layout/src/browser/drop-area/styles.module.less	新增 .drop_area CSS 类
packages/main-layout/src/browser/layout.service.ts	在 LayoutService 中新增多个方法以管理容器
packages/main-layout/src/browser/main-layout.contribution.ts	注册新的放置区域组件
packages/main-layout/src/browser/tabbar/bar.view.tsx	为 TabbarViewBase 组件添加 onDragEnd 事件处理
packages/main-layout/src/browser/tabbar/panel.view.tsx	更新 ContainerView 以支持自定义标题栏和可拖动性
packages/main-layout/src/browser/tabbar/tabbar.service.ts	在 TabbarService 中新增多个方法以增强交互性
packages/main-layout/src/common/main-layout.definition.ts	在 IMainLayoutService 接口中添加新方法
packages/terminal-next/src/browser/component/terminal.module.less	新增 .terminalContentWrapper CSS 类
packages/terminal-next/src/browser/component/terminal.widget.tsx	更新终端组件的渲染逻辑
packages/terminal-next/src/browser/contribution/terminal.view.ts	为终端组件注册添加 draggable: true
packages/terminal-next/src/browser/terminal.controller.ts	移除 _tabBarHandler 属性并添加相应的 getter 方法

序列图

sequenceDiagram
    participant User
    participant TabbarService
    participant LayoutService
    participant DropArea

    User->>TabbarService: 开始拖动容器
    TabbarService->>LayoutService: 显示放置区域
    LayoutService->>DropArea: 渲染放置区域
    User->>DropArea: 放置容器
    DropArea->>LayoutService: 移动容器
    LayoutService->>TabbarService: 更新容器位置
    TabbarService->>LayoutService: 隐藏放置区域

Loading

可能相关的 PR

• fix: render tabbar correctly on initial load #3895: 与标签渲染组件的 CSS 和渲染逻辑调整相关
• fix: right panel container view #4178: 涉及标签栏服务中容器可见性和状态管理的改进
• feat: terminal adds drag-and-drop #4300: 实现终端组件的拖放功能

建议审阅者

• Ricbet
• erha19
• zhanba

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 745519e and f1faff6.

📒 Files selected for processing (17)

• packages/ai-native/src/browser/layout/layout.module.less (1 hunks)
• packages/ai-native/src/browser/layout/tabbar.view.tsx (1 hunks)
• packages/core-browser/src/layout/layout.interface.ts (1 hunks)
• packages/main-layout/src/browser/accordion/titlebar.view.tsx (1 hunks)
• packages/main-layout/src/browser/default-config.ts (1 hunks)
• packages/main-layout/src/browser/drop-area/drop-area.tsx (1 hunks)
• packages/main-layout/src/browser/drop-area/styles.module.less (1 hunks)
• packages/main-layout/src/browser/layout.service.ts (1 hunks)
• packages/main-layout/src/browser/main-layout.contribution.ts (3 hunks)
• packages/main-layout/src/browser/tabbar/bar.view.tsx (1 hunks)
• packages/main-layout/src/browser/tabbar/panel.view.tsx (2 hunks)
• packages/main-layout/src/browser/tabbar/tabbar.service.ts (3 hunks)
• packages/main-layout/src/common/main-layout.definition.ts (1 hunks)
• packages/terminal-next/src/browser/component/terminal.module.less (2 hunks)
• packages/terminal-next/src/browser/component/terminal.widget.tsx (2 hunks)
• packages/terminal-next/src/browser/contribution/terminal.view.ts (1 hunks)
• packages/terminal-next/src/browser/terminal.controller.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.