Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add styles for dialog content and update file dialog logic #4337

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Feb 5, 2025

Types

  • 🎉 New Features

Background or solution

  • 统一样式
  • 支持在 Open Dialog 中输入路径后直接打开的交互

Changelog

add styles for dialog content and update file dialog logic

Summary by CodeRabbit

  • 样式
    • 对话框中的文件树节点视觉效果得到优化,调整了字体大小、圆角和边距,提升呈现精致度。
  • 新功能
    • 改进了文件选择对话框中路径显示与隐藏的逻辑,并更新了关闭按钮的样式,优化用户交互体验。

Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

Walkthrough

该 PR 在两个主要部分进行了修改。首先,在设计模块的样式文件中,为 .kt-dialog-content 内的 .design-file_tree_node 添加了新样式,包括字体大小、边框圆角以及外边距的设定。其次,在文件对话框组件中增加了对 selectPathdefaultUri 的处理逻辑:在无选中文件时隐藏相应的路径,并更新了依赖数组,同时将关闭按钮的类型从 'secondary' 修改为 'ghost',以便对话框响应不同状态的需求。

Changes

文件路径 更改摘要
packages/design/.../design.module.less .kt-dialog-content 内的 .design-file_tree_node 添加了 font-size: 13pxborder-radius: 4pxmargin: 0 5px 样式。
packages/file-tree-next/.../file-dialog.view.tsx FileDialog 组件中增加对 selectPathdefaultUri 的判断处理;更新依赖数组;将关闭按钮类型由 'secondary' 调整为 'ghost'。

Sequence Diagram(s)

sequenceDiagram
    participant U as 用户
    participant FD as FileDialog 组件
    participant DS as Dialog 服务

    U->>FD: 打开文件对话框
    FD->>FD: 检查是否有选中文件
    alt 存在 selectPath 且无选中文件
         FD->>DS: 隐藏 selectPath 路径
    end
    alt 存在 defaultUri
         FD->>DS: 隐藏 defaultUri 路径
    end
    FD->>FD: 更新依赖数组(包含 selectPath)
    FD->>U: 渲染对话框(关闭按钮类型为 ghost)
Loading

Suggested labels

💄 style change, 🎨 feature

Suggested reviewers

  • Ricbet
  • hacke2

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f563f0 and 95fbed7.

📒 Files selected for processing (2)
  • packages/design/src/browser/style/design.module.less (1 hunks)
  • packages/file-tree-next/src/browser/dialog/file-dialog.view.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
  • GitHub Check: unittest (ubuntu-latest, 18.x, node)
  • GitHub Check: build (ubuntu-latest, 20.x)
  • GitHub Check: unittest (macos-latest, 18.x, jsdom)
  • GitHub Check: build-windows
  • GitHub Check: unittest (macos-latest, 18.x, node)
  • GitHub Check: build (macos-latest, 20.x)
🔇 Additional comments (3)
packages/file-tree-next/src/browser/dialog/file-dialog.view.tsx (2)

86-87: 新增的路径选择逻辑看起来不错!

新增的 selectPath 处理逻辑使对话框的行为更加完整,依赖数组的更新也很准确。

Also applies to: 98-98


306-306: 按钮类型的修改符合设计规范

将关闭按钮类型从 'secondary' 改为 'ghost' 使按钮视觉层级更加合理。

packages/design/src/browser/style/design.module.less (1)

721-730: 样式更新提升了视觉一致性

为对话框内容添加的新样式改进了以下方面:

  • 字体大小设置为 13px,提高了可读性
  • 边框圆角和外边距的设置使布局更加协调

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.23%. Comparing base (5472a76) to head (66eeb51).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4337   +/-   ##
=======================================
  Coverage   54.23%   54.23%           
=======================================
  Files        1638     1638           
  Lines      100153   100153           
  Branches    21738    21746    +8     
=======================================
  Hits        54318    54318           
  Misses      38087    38087           
  Partials     7748     7748           
Flag Coverage Δ
jsdom 49.71% <ø> (ø)
node 12.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Aaaaash Aaaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 9d9400c into main Feb 5, 2025
11 checks passed
@erha19 erha19 deleted the feat/improve-file-dialog-input-ux branch February 5, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants