Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dispose model reference #691

Merged
merged 2 commits into from
Mar 23, 2022
Merged

fix: dispose model reference #691

merged 2 commits into from
Mar 23, 2022

Conversation

hacke2
Copy link
Member

@hacke2 hacke2 commented Mar 22, 2022

Types

  • 🐛 Bug Fixes

Background or solution

fixed #688

Changelog

dispose model reference

@hacke2 hacke2 requested review from MMhunter, erha19 and Aaaaash March 22, 2022 03:50
@erha19
Copy link
Member

erha19 commented Mar 22, 2022

#672 这个问题是不是也是关联的问题? @hacke2

Aaaaash
Aaaaash previously approved these changes Mar 22, 2022
Copy link
Member

@Aaaaash Aaaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hacke2
Copy link
Member Author

hacke2 commented Mar 22, 2022

#672 这个问题是不是也是关联的问题? @hacke2

看了下是另外一个问题,待会提个 PR 修一下

Copy link
Member

@bytemain bytemain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit 021fa8d into main Mar 23, 2022
@bytemain bytemain deleted the fix/dispose-model-reference branch March 23, 2022 02:44
@erha19 erha19 mentioned this pull request Apr 7, 2022
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 已删除的文件不应该出现搜索结果页
4 participants