Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more editor configuration #704

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Conversation

bytemain
Copy link
Member

Types

  • 🎉 New Features

Background or solution

之后可以安排一个专项是设置项优化以及各设置项的 i18n 优化。这次就做了一点点,慢慢来吧。

Changelog

support more editor configuration

@bytemain bytemain force-pushed the feat/terminal-preference branch from d914a97 to fc9c819 Compare March 22, 2022 11:12
@codecov-commenter
Copy link

Codecov Report

Merging #704 (25e6b41) into main (fd11757) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
- Coverage   58.62%   58.60%   -0.02%     
==========================================
  Files        1208     1208              
  Lines       74746    74751       +5     
  Branches    15511    15512       +1     
==========================================
- Hits        43820    43809      -11     
- Misses      28188    28202      +14     
- Partials     2738     2740       +2     
Impacted Files Coverage Δ
packages/core-browser/src/core-preferences.ts 71.42% <ø> (ø)
packages/core-browser/src/preferences/settings.ts 100.00% <ø> (ø)
...ackages/editor/src/browser/preference/converter.ts 90.14% <ø> (ø)
packages/editor/src/browser/preference/schema.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...erences/src/browser/preference-settings.service.ts 79.86% <50.00%> (+0.69%) ⬆️
packages/preferences/src/common/preference.ts 31.25% <50.00%> (+3.97%) ⬆️
...es/src/browser/userstorage/user-storage.service.ts 57.30% <0.00%> (-14.61%) ⬇️
packages/file-service/src/browser/watcher.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd11757...25e6b41. Read the comment docs.

@erha19 erha19 merged commit 14b148e into main Mar 23, 2022
@erha19 erha19 deleted the feat/terminal-preference branch March 23, 2022 02:46
@erha19 erha19 mentioned this pull request Apr 7, 2022
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants