Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: load lodash method from lodash core #705

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Mar 22, 2022

Types

  • 🪚 Refactors

Background or solution

close #701

Changelog

load lodash method from lodash core

@erha19 erha19 force-pushed the refactor/just-use-lodash branch from a6a0f49 to 36f2eca Compare March 23, 2022 01:52
@erha19 erha19 force-pushed the refactor/just-use-lodash branch from 36f2eca to fb1933d Compare March 23, 2022 02:53
@erha19
Copy link
Member Author

erha19 commented Mar 23, 2022

/publish

@github-actions
Copy link
Contributor

🎉 Pre-Release version 2.16.2-next-1648004649.0 publish successful! You can install prerelease version via npm install package@2.16.2-next-1648004649.0 @erha19

@codecov-commenter
Copy link

Codecov Report

Merging #705 (fb1933d) into main (14b148e) will increase coverage by 0.01%.
The diff coverage is 90.62%.

@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   58.60%   58.61%   +0.01%     
==========================================
  Files        1209     1209              
  Lines       74770    74770              
  Branches    15515    15515              
==========================================
+ Hits        43817    43827      +10     
+ Misses      28213    28204       -9     
+ Partials     2740     2739       -1     
Impacted Files Coverage Δ
...s/monaco-enhance/src/browser/folded-code-widget.ts 0.00% <0.00%> (ø)
packages/terminal-next/src/browser/terminal.api.ts 0.00% <0.00%> (ø)
packages/comments/src/browser/comments.service.ts 52.69% <75.00%> (ø)
packages/core-browser/src/layout/layout-state.ts 63.79% <100.00%> (ø)
...-browser/src/menu/next/renderer/ctxmenu/browser.ts 57.14% <100.00%> (ø)
packages/core-browser/src/utils/react-hooks.ts 71.18% <100.00%> (ø)
packages/debug/src/browser/debug-session.ts 14.63% <100.00%> (ø)
packages/debug/src/browser/editor/debug-model.ts 53.00% <100.00%> (ø)
packages/debug/src/browser/model/debug-watch.ts 91.54% <100.00%> (ø)
.../src/browser/view/console/debug-console-session.ts 26.19% <100.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b148e...fb1933d. Read the comment docs.

Copy link
Member

@bytemain bytemain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit 74f341d into main Mar 23, 2022
@bytemain bytemain deleted the refactor/just-use-lodash branch March 23, 2022 04:12
@erha19 erha19 mentioned this pull request Apr 7, 2022
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 框架隐式依赖了 file-service 模块中的 lodash.debounce 依赖
3 participants