Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use pty process name as terminal title #732

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Mar 25, 2022

Types

  • 🎉 New Features

Background or solution

closed: #719

before

image

after
image

根据运行中的命令动态更新终端 icon

term-icon.mp4

Changelog

  • use pty process name as terminal title

@Aaaaash Aaaaash force-pushed the feat/use-pty-process-name-as-terminal-title branch from fcd3b0f to 1383ad1 Compare March 25, 2022 09:57
@codecov-commenter
Copy link

Codecov Report

Merging #732 (a0b47e4) into main (a474f8c) will decrease coverage by 0.00%.
The diff coverage is 58.06%.

@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   58.60%   58.60%   -0.01%     
==========================================
  Files        1209     1209              
  Lines       74863    74892      +29     
  Branches    15556    15562       +6     
==========================================
+ Hits        43876    43892      +16     
- Misses      28244    28256      +12     
- Partials     2743     2744       +1     
Impacted Files Coverage Δ
packages/components/src/icon/iconfont/iconMap.ts 100.00% <ø> (ø)
packages/terminal-next/src/common/pty.ts 100.00% <ø> (ø)
packages/terminal-next/src/common/service.ts 100.00% <ø> (ø)
.../terminal-next/src/node/terminal.service.client.ts 25.51% <0.00%> (-0.81%) ⬇️
...ackages/terminal-next/src/node/terminal.service.ts 40.60% <14.28%> (-1.47%) ⬇️
...ages/terminal-next/src/browser/terminal.service.ts 54.23% <50.00%> (-0.15%) ⬇️
...ackages/terminal-next/src/browser/terminal.view.ts 84.72% <50.00%> (-0.26%) ⬇️
...ckages/core-browser/src/style/icon/ide-iconfont.ts 100.00% <100.00%> (ø)
...kages/terminal-next/src/browser/terminal.client.ts 74.86% <100.00%> (+0.28%) ⬆️
...inal-next/src/browser/terminal.internal.service.ts 50.70% <100.00%> (+1.42%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b205b...a0b47e4. Read the comment docs.

Copy link
Member

@bytemain bytemain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit 538c9ac into main Mar 28, 2022
@bytemain bytemain deleted the feat/use-pty-process-name-as-terminal-title branch March 28, 2022 03:21
@erha19 erha19 mentioned this pull request Apr 7, 2022
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 终端标签栏根据运行命令自动切换为对应的 logo
3 participants