Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make icon theme apply correctly #775

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 1, 2022

Types

  • 🐛 Bug Fixes

Background or solution

close #774

Changelog

make icon theme apply correctly

@codecov-commenter
Copy link

Codecov Report

Merging #775 (58f0b15) into v2.16 (d746ce6) will decrease coverage by 0.02%.
The diff coverage is 44.06%.

@@            Coverage Diff             @@
##            v2.16     #775      +/-   ##
==========================================
- Coverage   59.00%   58.98%   -0.03%     
==========================================
  Files        1209     1209              
  Lines       74703    74742      +39     
  Branches    15495    15510      +15     
==========================================
+ Hits        44080    44087       +7     
- Misses      27918    27946      +28     
- Partials     2705     2709       +4     
Impacted Files Coverage Δ
...omponents/src/recycle-tree/tree/model/TreeModel.ts 80.64% <ø> (ø)
...ages/quick-open/src/browser/quick-input-service.ts 22.50% <0.00%> (-1.83%) ⬇️
...ages/quick-open/src/browser/quickInput.inputBox.ts 7.61% <0.00%> (-2.14%) ⬇️
...xt/src/browser/services/file-tree-model.service.ts 54.12% <35.48%> (-0.40%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.17% <66.66%> (-0.05%) ⬇️
packages/theme/src/browser/icon.service.ts 83.68% <75.00%> (-0.28%) ⬇️
...es/file-tree-next/src/browser/file-tree.service.ts 62.33% <80.95%> (-0.12%) ⬇️
packages/components/src/recycle-tree/tree/Tree.ts 91.30% <100.00%> (ø)
packages/file-service/src/common/files.ts 87.17% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009ccd9...58f0b15. Read the comment docs.

Copy link
Member

@yantze yantze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erha19 erha19 merged commit 50693fb into v2.16 Apr 2, 2022
@erha19 erha19 deleted the fix/icon-theme/apply-correctly branch April 2, 2022 02:27
@erha19 erha19 mentioned this pull request Apr 7, 2022
64 tasks
bytemain pushed a commit that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants