Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve filetree snapshot recovery progress #776

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 1, 2022

Types

  • 🐛 Bug Fixes

Background or solution

  • 移除了 TreeModel 初始化阶段对 labelService 多余的响应,解决首屏闪烁问题
  • 确保文件树快照恢复完成后再进行文件树的定位

Changelog

improve filetree snapshot recovery progress

@codecov-commenter
Copy link

Codecov Report

Merging #776 (8cc089d) into v2.16 (d746ce6) will decrease coverage by 0.01%.
The diff coverage is 48.87%.

@@            Coverage Diff             @@
##            v2.16     #776      +/-   ##
==========================================
- Coverage   59.00%   58.98%   -0.02%     
==========================================
  Files        1209     1209              
  Lines       74703    74752      +49     
  Branches    15495    15512      +17     
==========================================
+ Hits        44080    44094      +14     
- Misses      27918    27948      +30     
- Partials     2705     2710       +5     
Impacted Files Coverage Δ
...omponents/src/recycle-tree/tree/model/TreeModel.ts 80.64% <ø> (ø)
...ages/quick-open/src/browser/quick-input-service.ts 22.50% <0.00%> (-1.83%) ⬇️
...ages/quick-open/src/browser/quickInput.inputBox.ts 7.61% <0.00%> (-2.14%) ⬇️
...xt/src/browser/services/file-tree-model.service.ts 54.47% <54.71%> (-0.04%) ⬇️
...es/file-tree-next/src/browser/file-tree.service.ts 62.33% <80.95%> (-0.12%) ⬇️
packages/components/src/recycle-tree/tree/Tree.ts 91.30% <100.00%> (ø)
packages/file-service/src/common/files.ts 87.17% <100.00%> (ø)
packages/core-common/src/node/port.ts 46.96% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009ccd9...8cc089d. Read the comment docs.

Copy link
Member

@yantze yantze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit aab465c into v2.16 Apr 2, 2022
@erha19 erha19 deleted the fix/improve-file-tree-snapshot-recovery-progress branch April 2, 2022 02:24
@erha19 erha19 mentioned this pull request Apr 7, 2022
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants