Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug hover overflow hidden #781

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix: debug hover overflow hidden #781

merged 1 commit into from
Apr 6, 2022

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Apr 2, 2022

Types

  • 🐛 Bug Fixes

Background or solution

before
image

after
image

Changelog

修复 debug hover 变量面板会被溢出隐藏的问题

@Ricbet Ricbet requested review from hacke2, erha19 and Aaaaash April 2, 2022 04:14
@codecov-commenter
Copy link

Codecov Report

Merging #781 (deaf699) into main (154d373) will decrease coverage by 0.02%.
The diff coverage is 13.95%.

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   58.59%   58.57%   -0.03%     
==========================================
  Files        1209     1210       +1     
  Lines       74915    74969      +54     
  Branches    15561    15586      +25     
==========================================
+ Hits        43900    43916      +16     
- Misses      28268    28299      +31     
- Partials     2747     2754       +7     
Impacted Files Coverage Δ
...ages/quick-open/src/browser/quick-input-service.ts 22.50% <0.00%> (-1.83%) ⬇️
...ages/quick-open/src/browser/quickInput.inputBox.ts 7.61% <0.00%> (-2.14%) ⬇️
...ackages/terminal-next/src/browser/terminal.view.ts 84.40% <50.00%> (-0.32%) ⬇️
packages/core-browser/src/components/index.ts 100.00% <100.00%> (ø)
packages/core-common/src/utils/index.ts 100.00% <100.00%> (ø)
packages/core-common/src/utils/markdown.ts 100.00% <100.00%> (ø)
...l-next/src/browser/terminal.environment.service.ts 81.92% <100.00%> (ø)
...es/src/browser/userstorage/user-storage.service.ts 57.30% <0.00%> (-5.62%) ⬇️
packages/file-service/src/browser/watcher.ts 95.65% <0.00%> (-4.35%) ⬇️
packages/theme/src/browser/icon.service.ts 83.68% <0.00%> (-0.28%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 574ebf8...deaf699. Read the comment docs.

@Ricbet Ricbet self-assigned this Apr 2, 2022
Copy link
Member

@bytemain bytemain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 4cb50f9 into main Apr 6, 2022
@erha19 erha19 deleted the fix/debug-hover-overflow branch April 6, 2022 07:35
@erha19 erha19 mentioned this pull request Apr 7, 2022
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants