Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve file tree navigator #818

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 12, 2022

Types

  • 🐛 Bug Fixes

Background or solution

improve keybinding behavior

Changelog

improve file tree navigator

@erha19 erha19 requested a review from bytemain April 12, 2022 10:56
@bytemain
Copy link
Member

#814 中提到的内容还没有实现:

image

其他的 behavior works good,跟预期一样~

@erha19
Copy link
Member Author

erha19 commented Apr 13, 2022

没注意看,#814 的需求单独开 PR 实现好了

@bytemain
Copy link
Member

/publish

@github-actions
Copy link
Contributor

🎉 Pre-Release version 2.16.10-next-1649820251.0 publish successful! You can install prerelease version via npm install package@2.16.10-next-1649820251.0 @bytemain

@erha19
Copy link
Member Author

erha19 commented Apr 13, 2022

给删除添加了队列操作逻辑,整体删除更加顺滑
Kapture 2022-04-13 at 11 30 39

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #818 (d32bcb9) into main (c512d51) will increase coverage by 0.00%.
The diff coverage is 63.12%.

@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   58.56%   58.57%           
=======================================
  Files        1211     1211           
  Lines       75003    75064   +61     
  Branches    15593    15616   +23     
=======================================
+ Hits        43929    43971   +42     
- Misses      28319    28333   +14     
- Partials     2755     2760    +5     
Impacted Files Coverage Δ
...ackages/debug/src/browser/debug-session-manager.ts 67.00% <0.00%> (-0.23%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 62.68% <0.00%> (-0.07%) ⬇️
...c/browser/abstract-resource-preference-provider.ts 83.33% <0.00%> (+0.09%) ⬆️
packages/search/src/common/content-search.ts 67.90% <ø> (ø)
...ages/file-service/src/node/file-service-watcher.ts 68.88% <40.00%> (-2.30%) ⬇️
...xt/src/browser/services/file-tree-model.service.ts 54.22% <40.81%> (+0.34%) ⬆️
...rences/src/browser/folders-preferences-provider.ts 65.77% <50.00%> (-0.90%) ⬇️
...kages/components/src/recycle-tree/tree/TreeNode.ts 77.03% <74.57%> (-0.52%) ⬇️
packages/search/src/browser/search.service.ts 41.25% <75.00%> (-0.10%) ⬇️
...es/file-tree-next/src/browser/file-tree.service.ts 62.58% <79.16%> (+0.25%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9316c...d32bcb9. Read the comment docs.

@bytemain bytemain merged commit e28ecb7 into main Apr 13, 2022
@bytemain bytemain deleted the fix/file-tree/improve-keybinding-ux branch April 13, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants