-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update renovate.json to group updates #112
Conversation
"description": "All packages related to spur node framework" | ||
}, | ||
{ | ||
"packagePatterns": ["prettier", "-prettier"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prettier
also cover prettier-
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately no. I'll have to recheck but it required it in another repo.
"description": "All packages related to the eslint plugin" | ||
}, | ||
{ | ||
"packagePatterns": ["jest", "@types/jest", "nock", "jest-"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to extend from Renovate's built-in Jest + types group? group:jestPlusTypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I'll review this as a whole. I also recall Arnold mentioning that we have predefined config so I don't have to do this, but have not done the research yet. For now I am sticking to the common config we use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two comments but nothing blocking.
No description provided.