-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flex python version to make all 3.10 versions compatible #406
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #406 +/- ##
==========================================
+ Coverage 85.67% 86.20% +0.53%
==========================================
Files 89 95 +6
Lines 2101 2596 +495
==========================================
+ Hits 1800 2238 +438
- Misses 301 358 +57
|
I changed my local python version to 3.10.13 (pyenv + poetry), built a wheel, uploaded it to the bucket, and installed in dataproc (3.10.8). Everything seems to be working without problems. |
You need to change how we parse the Python version in
For consistency and simplicity, I think it is a good idea to lock the version we use for development (defined in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Requiring a very specific version of python package 3.10.8 might be very stringent. This PR attempts to allow the package installation in any 3.10.X version as a first step.