Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reorder commit types in release notes template #419

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

ireneisdoomed
Copy link
Contributor

Proposed order:
order = ["feat", "fix", "docs", "style", "refactor", "perf", "test", "build", "ci", "chore", "revert"]

I don't know how to test it...

@ireneisdoomed ireneisdoomed requested a review from d0choa January 15, 2024 16:37
@d0choa
Copy link
Collaborator

d0choa commented Jan 15, 2024

poetry run + semantic release + --noop option. Let me know

@d0choa
Copy link
Collaborator

d0choa commented Jan 15, 2024

(in release branches)

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Comparison is base (42b366c) 85.67% compared to head (75d7c68) 86.20%.
Report is 66 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #419      +/-   ##
==========================================
+ Coverage   85.67%   86.20%   +0.53%     
==========================================
  Files          89       95       +6     
  Lines        2101     2596     +495     
==========================================
+ Hits         1800     2238     +438     
- Misses        301      358      +57     
Files Coverage Δ
src/airflow/dags/common_airflow.py 90.38% <100.00%> (ø)
src/airflow/dags/dag_preprocess.py 100.00% <ø> (ø)
src/airflow/dags/finngen_preprocess.py 100.00% <100.00%> (ø)
src/airflow/dags/gwas_catalog_harmonisation.py 43.47% <ø> (ø)
src/airflow/dags/gwas_curation_update.py 100.00% <100.00%> (ø)
src/otg/cli.py 91.66% <100.00%> (+21.66%) ⬆️
src/otg/common/session.py 87.50% <100.00%> (+0.32%) ⬆️
src/otg/config.py 100.00% <100.00%> (ø)
src/otg/dataset/dataset.py 91.80% <100.00%> (ø)
src/otg/dataset/l2g_feature_matrix.py 82.92% <100.00%> (+7.31%) ⬆️
... and 35 more

Copy link
Collaborator

@d0choa d0choa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready from my perspective...

@d0choa d0choa changed the title refactor: reorder commit types in release notes template ci: reorder commit types in release notes template Jan 16, 2024
@ireneisdoomed ireneisdoomed merged commit 1435548 into dev Jan 16, 2024
3 checks passed
@DSuveges DSuveges deleted the il-reorder-release-template branch January 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants