Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate __version__ in __init__.py #421

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

d0choa
Copy link
Collaborator

@d0choa d0choa commented Jan 16, 2024

This is falling out of fashion when using modern build systems (e.g. poetry). More info here:
https://stackoverflow.com/questions/72167802/adding-version-attribute-to-python-module

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Comparison is base (42b366c) 85.67% compared to head (0768600) 86.20%.
Report is 67 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #421      +/-   ##
==========================================
+ Coverage   85.67%   86.20%   +0.53%     
==========================================
  Files          89       95       +6     
  Lines        2101     2595     +494     
==========================================
+ Hits         1800     2237     +437     
- Misses        301      358      +57     
Files Coverage Δ
src/airflow/dags/common_airflow.py 90.38% <100.00%> (ø)
src/airflow/dags/dag_preprocess.py 100.00% <ø> (ø)
src/airflow/dags/finngen_preprocess.py 100.00% <100.00%> (ø)
src/airflow/dags/gwas_catalog_harmonisation.py 43.47% <ø> (ø)
src/airflow/dags/gwas_curation_update.py 100.00% <100.00%> (ø)
src/otg/__init__.py 100.00% <ø> (ø)
src/otg/cli.py 91.66% <100.00%> (+21.66%) ⬆️
src/otg/common/session.py 87.50% <100.00%> (+0.32%) ⬆️
src/otg/config.py 100.00% <100.00%> (ø)
src/otg/dataset/dataset.py 91.80% <100.00%> (ø)
... and 36 more

Copy link
Contributor

@ireneisdoomed ireneisdoomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Found a nice ticket in poetry about this. With info to extract the version from the package metadata using importlib.metadata

@d0choa d0choa merged commit 229f4ff into dev Jan 16, 2024
3 checks passed
@d0choa d0choa deleted the do_remove_init_version branch January 16, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants