-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LD index and block matrix extraction for a studyLocus #463
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #463 +/- ##
==========================================
+ Coverage 85.67% 85.94% +0.27%
==========================================
Files 89 100 +11
Lines 2101 2875 +774
==========================================
+ Hits 1800 2471 +671
- Misses 301 404 +103
|
Is it ready for the review? |
I haven't yet added tests for the functions I have added to study_locus.py @DSuveges |
Nice. I'll review this PR together with the Z-score one today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is the layout of the locus index retriever function. Which functionality is more or less already in this function: get_ld_variants
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think all makes sense now. In a separate effort we can update the other function that the ld index generation uses.
Adds get_gnomad_matrix() function to study_locus.py. This function takes a study locus, finds the relevant study ID, extracts the major ancestry, and then returns the ancestry specific hail ld index and block matrices for that window.