Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataset): add Dataset.filter to create a new dataset instance with filtered data #470

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

ireneisdoomed
Copy link
Contributor

The new Dataset.filter util was a request of @DSuveges. It is useful to apply filters on the data while maintaining the datatype.

Important to note that this solutions creates different versions (instances) of the dataset. More specifically, as many instances as filters we apply.

I've added the method to the User Guide docs.

@ireneisdoomed ireneisdoomed changed the title feat(dataset): add filter method to create a new dataset instance with the data filtered feat(dataset): add Dataset.filter to create a new dataset instance with filtered data Feb 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 166 lines in your changes are missing coverage. Please review.

Comparison is base (42b366c) 85.67% compared to head (92d070c) 86.07%.
Report is 107 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #470      +/-   ##
==========================================
+ Coverage   85.67%   86.07%   +0.40%     
==========================================
  Files          89       96       +7     
  Lines        2101     2636     +535     
==========================================
+ Hits         1800     2269     +469     
- Misses        301      367      +66     
Files Coverage Δ
src/airflow/dags/common_airflow.py 90.38% <100.00%> (ø)
src/airflow/dags/dag_preprocess.py 100.00% <ø> (ø)
src/airflow/dags/finngen_preprocess.py 100.00% <100.00%> (ø)
src/airflow/dags/gwas_curation_update.py 100.00% <100.00%> (ø)
src/gentropy/__init__.py 100.00% <ø> (ø)
src/gentropy/assets/__init__.py 100.00% <ø> (ø)
src/gentropy/assets/data/__init__.py 100.00% <ø> (ø)
src/gentropy/assets/schemas/__init__.py 100.00% <ø> (ø)
src/gentropy/cli.py 91.66% <100.00%> (ø)
src/gentropy/common/Liftover.py 80.64% <ø> (ø)
... and 77 more

... and 22 files with indirect coverage changes

Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense! Thanks @ireneisdoomed

@DSuveges DSuveges merged commit fcf77de into dev Feb 6, 2024
3 checks passed
@ireneisdoomed ireneisdoomed deleted the il-filter-dataset branch February 7, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants