Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor updates and bug fixes #543

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix: minor updates and bug fixes #543

merged 3 commits into from
Apr 24, 2024

Conversation

DSuveges
Copy link
Contributor

✨ Context

Upon QCing the 24.03 data release a few issues surfaced. This pr meant to address them.

🛠 What does this PR implement

  • Update the configuration of the variant index step to point to the right credible set dataset.
  • Renaming the credible set dataset generated by the GWAS Catalog pre-process step to make their content more obvious.
  • Applying credible interval filter on the PICSed loci to ensure only the 99% credible sets remain.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@DSuveges DSuveges marked this pull request as ready for review April 23, 2024 15:02
@DSuveges DSuveges requested review from d0choa and ireneisdoomed and removed request for d0choa April 23, 2024 16:51
Copy link
Collaborator

@d0choa d0choa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go into detail to check every changed path, so I assume all changes are for good.

Nothing controversial and important fix for the PICS pipeline

@DSuveges DSuveges merged commit e2f8e87 into dev Apr 24, 2024
4 checks passed
@DSuveges DSuveges deleted the ds_3256_release_update branch June 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow bug Something isn't working size-S Step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants