Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing all duplicated variants in sumstats for finemapping functions #574

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Daniel-Considine
Copy link
Contributor

@Daniel-Considine Daniel-Considine commented Apr 10, 2024

✨ Context

Some sumstats files have duplicated variant rows, where it isn't clear which is the correct entry. This causes errors in the finemapping pipelines, specifically when extracting the gnomad blockmatrix.

🛠 What does this PR implement

adds a few lines to remove ALL variants that appear more than once in the sumstats prior to finemapping.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added bug Something isn't working Step size-XS labels Apr 10, 2024
@Daniel-Considine Daniel-Considine merged commit ecd8063 into dev Apr 10, 2024
4 checks passed
@Daniel-Considine Daniel-Considine deleted the dc_finemapper branch April 10, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size-XS Step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants