Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dockerise gentropy python package #579

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: dockerise gentropy python package #579

merged 2 commits into from
Apr 23, 2024

Conversation

ireneisdoomed
Copy link
Contributor

🛠 What does this PR implement

Dockerfile to dockerise the python application. Image can be built using:

docker build . --tag gentropy_app

Steps can be run using:

docker run gentropy_app

🙈 Missing

  • Slimming down the image size
  • Github action to automatically build the image
  • Unit test image build is correct

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@ireneisdoomed ireneisdoomed merged commit 78fcf1b into dev Apr 23, 2024
4 checks passed
@ireneisdoomed ireneisdoomed deleted the ildo_dockerize branch April 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants