Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github action to upload docker image to artifact registry #588

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

d0choa
Copy link
Collaborator

@d0choa d0choa commented Apr 26, 2024

✨ Context

It would be handy to have a gentropy image of the dev branch available in GCP at all times.

🛠 What does this PR implement

This GitHub Action aims to build the image of gentropy from the Dockerfile and upload it to the GCP Artefact Registry.

🙈 Missing

  • I can't make sure the action runs properly locally. It's using the secrets in GitHub. It's unlikely to work in the first shot
  • It only deploys the dev branch for now. We could have docker images for each release as well if this works.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@d0choa d0choa marked this pull request as ready for review April 26, 2024 15:52
Copy link
Contributor

@ireneisdoomed ireneisdoomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if it works!

@d0choa d0choa merged commit da2c75d into dev Apr 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants