Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fine-mapping simulations class #618

Merged
merged 4 commits into from
May 22, 2024
Merged

feat: fine-mapping simulations class #618

merged 4 commits into from
May 22, 2024

Conversation

addramir
Copy link
Contributor

@addramir addramir commented May 21, 2024 •
edited
Loading

✨ Context

PR adds the step to perform simulations for FM benchmarking. Also it adds the jupyter notebook that uses this step.

🛠 What does this PR implement

  1. Step/class for fine-mapping simualtions/benchmarking
  2. Ipynb with simulations

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@addramir addramir marked this pull request as ready for review May 21, 2024 19:14
@addramir addramir merged commit e355970 into dev May 22, 2024
4 checks passed
@addramir addramir deleted the yt_fm_simulations branch May 22, 2024 09:50
project-defiant pushed a commit that referenced this pull request Jun 14, 2024
@addramir @Daniel-Considine @project-defiant
feat: fine-mapping simulations class (#618)
7d73b1d 
* feat: fine-mapping simulations class

* fix: fix of function descriptions

* Update finemapping_simulations.py

---------

Co-authored-by: Daniel-Considine <113430683+Daniel-Considine@users.noreply.github.com>
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
Revert "feat: fine-mapping simulations class (#618)"
b649066 
This reverts commit 7d73b1d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel-Considine Daniel-Considine Daniel-Considine approved these changes

Assignees
No one assigned
Labels
Feature size-L Step
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addramir @Daniel-Considine